Contributors: 5
Author Tokens Token Proportion Commits Commit Proportion
Alexis Lothoré 559 85.74% 1 20.00%
Lang Xu 61 9.36% 1 20.00%
Weiming Shi 20 3.07% 1 20.00%
Roman Gushchin 11 1.69% 1 20.00%
John Fastabend 1 0.15% 1 20.00%
Total 652 5 


// SPDX-License-Identifier: GPL-2.0

#include <unistd.h>
#include <sys/socket.h>
#include <test_progs.h>
#include "cgroup_helpers.h"
#include "network_helpers.h"
#include "cgroup_storage.skel.h"

#define TEST_CGROUP "/test-bpf-cgroup-storage-buf/"
#define TEST_NS "cgroup_storage_ns"
#define PING_CMD "ping localhost -c 1 -W 1 -q"

static int setup_network(struct nstoken **token)
{
	SYS(fail, "ip netns add %s", TEST_NS);
	*token = open_netns(TEST_NS);
	if (!ASSERT_OK_PTR(*token, "open netns"))
		goto cleanup_ns;
	SYS(cleanup_ns, "ip link set lo up");

	return 0;

cleanup_ns:
	SYS_NOFAIL("ip netns del %s", TEST_NS);
fail:
	return -1;
}

static void cleanup_network(struct nstoken *ns)
{
	close_netns(ns);
	SYS_NOFAIL("ip netns del %s", TEST_NS);
}

void test_cgroup_storage(void)
{
	struct bpf_cgroup_storage_key key;
	struct cgroup_storage *skel;
	struct nstoken *ns = NULL;
	unsigned long long value;
	int cgroup_fd;
	int err;

	cgroup_fd = cgroup_setup_and_join(TEST_CGROUP);
	if (!ASSERT_OK_FD(cgroup_fd, "create cgroup"))
		return;

	if (!ASSERT_OK(setup_network(&ns), "setup network"))
		goto cleanup_cgroup;

	skel = cgroup_storage__open_and_load();
	if (!ASSERT_OK_PTR(skel, "load program"))
		goto cleanup_network;

	skel->links.bpf_prog =
		bpf_program__attach_cgroup(skel->progs.bpf_prog, cgroup_fd);
	if (!ASSERT_OK_PTR(skel->links.bpf_prog, "attach program"))
		goto cleanup_progs;

	/* Check that one out of every two packets is dropped */
	err = SYS_NOFAIL(PING_CMD);
	ASSERT_OK(err, "first ping");
	err = SYS_NOFAIL(PING_CMD);
	ASSERT_NEQ(err, 0, "second ping");
	err = SYS_NOFAIL(PING_CMD);
	ASSERT_OK(err, "third ping");

	err = bpf_map__get_next_key(skel->maps.cgroup_storage, NULL, &key,
				    sizeof(key));
	if (!ASSERT_OK(err, "get first key"))
		goto cleanup_progs;
	err = bpf_map__lookup_elem(skel->maps.cgroup_storage, &key, sizeof(key),
				   &value, sizeof(value), 0);
	if (!ASSERT_OK(err, "first packet count read"))
		goto cleanup_progs;

	/* Add one to the packet counter, check again packet filtering */
	value++;
	err = bpf_map__update_elem(skel->maps.cgroup_storage, &key, sizeof(key),
				   &value, sizeof(value), 0);
	if (!ASSERT_OK(err, "increment packet counter"))
		goto cleanup_progs;
	err = SYS_NOFAIL(PING_CMD);
	ASSERT_OK(err, "fourth ping");
	err = SYS_NOFAIL(PING_CMD);
	ASSERT_NEQ(err, 0, "fifth ping");
	err = SYS_NOFAIL(PING_CMD);
	ASSERT_OK(err, "sixth ping");

	err = bpf_map__get_next_key(skel->maps.cgroup_storage, &key, &key,
				    sizeof(key));
	ASSERT_ERR(err, "bpf_map__get_next_key should fail");
	ASSERT_EQ(errno, ENOENT, "no second key");

cleanup_progs:
	cgroup_storage__destroy(skel);
cleanup_network:
	cleanup_network(ns);
cleanup_cgroup:
	close(cgroup_fd);
	cleanup_cgroup_environment();
}

void test_cgroup_storage_oob(void)
{
	struct cgroup_storage *skel;
	int cgroup_fd, sock_fd;

	cgroup_fd = cgroup_setup_and_join(TEST_CGROUP);
	if (!ASSERT_OK_FD(cgroup_fd, "create cgroup"))
		return;

	/* Load and attach BPF program */
	skel = cgroup_storage__open_and_load();
	if (!ASSERT_OK_PTR(skel, "cgroup_storage__open_and_load"))
		goto cleanup_cgroup;

	skel->links.trigger_oob = bpf_program__attach_cgroup(skel->progs.trigger_oob,
							      cgroup_fd);
	if (!ASSERT_OK_PTR(skel->links.trigger_oob, "attach_cgroup"))
		goto cleanup_skel;

	/* Create a socket to trigger cgroup/sock_create hook.
	 * This will execute our BPF program and trigger the OOB read
	 * if the bug is present (before the fix).
	 */
	sock_fd = socket(AF_INET, SOCK_DGRAM, 0);
	if (!ASSERT_OK_FD(sock_fd, "create socket"))
		goto cleanup_skel;

	close(sock_fd);

	/* If we reach here without a kernel panic or KASAN report,
	 * the test passes (the fix is working).
	 */

cleanup_skel:
	cgroup_storage__destroy(skel);
cleanup_cgroup:
	close(cgroup_fd);
	cleanup_cgroup_environment();
}